imsweb / algorithms

Java implementation of cancer-related algorithms (NHIA, NAPIIA, Survival Time, etc...)
Other
6 stars 6 forks source link

Unknown country code in NHIA algorithm #49

Closed WerthPADOH closed 5 years ago

WerthPADOH commented 5 years ago

In the line below, I'm not sure which country "SWK" is. I didn't find it in the ISO-3166 table or SEER's country codes.

https://github.com/imsweb/algorithms/blob/b02faa92f1abb992a18387cca4abddae52cb3420/src/main/java/com/imsweb/algorithms/nhia/NhiaUtils.java#L81

depryf commented 5 years ago

"SWK" is the old SEER code for "Slovakia", but it was changed to "SVK" a few years ago. I am not sure why this algorithm was not updated (especially since I see other country codes that were updated).

I am going to investigate a little bit more before fixing this.

depryf commented 5 years ago

This library is supposed to implement the same logic as the corresponding SAS program provided by NAACCR (https://www.naaccr.org/analysis-and-data-improvement-tools/#NHAPIIA). It turns out that program is also missing the new "SVK" code. That is going to be fixed and a new version is going to be uploaded on the NAACCR website; when that happens, I will add the new code to this library as well.

depryf commented 5 years ago

The SAS code has not been fixed yet, but it should be soon. Since this library is going to be released soon, I added the missing "SVK" code to that list.