search

imsweb / django-saml-sp

A Django application for running one or more SAML service providers (SP)
BSD 3-Clause "New" or "Revised" License
15 stars 10 forks source link

Use Django admin base_site templates #17

Open JobDoesburg opened 2 years ago

JobDoesburg commented 2 years ago

Removes a bootstrap dependency and uses the Django admin base_site template for IdP test and error pages

dcwatson commented 2 years ago

Thanks for the PR, I like the idea! However, while it does remove the bootstrap dependency, it also means you need to have django.contrib.admin installed to find the base templates. In reality, these templates should be overridden for production sites anyway, but I think having a default that works without the admin installed is probably a good thing.

I'll leave this open to think on for a little while. Let me know if you have any more thoughts about it.