search

imsweb / django-saml-sp

A Django application for running one or more SAML service providers (SP)
BSD 3-Clause "New" or "Revised" License
15 stars 10 forks source link

Set default_auto_field on AppConfig #18

Closed JobDoesburg closed 1 year ago

dcwatson commented 2 years ago

Thanks for the PR. I'm curious what the benefit to specifying it at the app level is? It seems that the app-level setting is most useful for apps that have known PK requirements that should override the project's DEFAULT_AUTO_FIELD setting -- I'm not sure that applies to this app. Happy to hear rationale otherwise, though.

JobDoesburg commented 2 years ago

If the default_auto_field is not set on the model level, and it is set to django.db.models.BigAutoField in settings, a migration will need to be created for this app. Also, when you don't override the setting, Django will display a warning.