Valid certification expire date set in Metadata xml

imsweb / django-saml-sp

A Django application for running one or more SAML service providers (SP)

BSD 3-Clause "New" or "Revised" License

15 stars 10 forks source link

Closed nishitchittora closed 2 years ago

nishitchittora commented 3 years ago

Currently, metadata XML doesn't set a valid expire date.

So, in code of onelogin/python3-saml set 2 days valid date

        if valid_until is None:
            valid_until = int(time()) + cls.TIME_VALID

where TIME_VALID = 172800 # 2 days

which is not correct. Ideally it should be certificate expire date

nishitchittora commented 3 years ago

@dcwatson I have created this PR.

dcwatson commented 2 years ago

Done as part of d8aad81452e9e28ef1d7e85e35dff7f271a86aa8