Closed ctmay4 closed 1 year ago
This issue was closed but there were two parts. One was Spotbugs, the other was Sonarcloud code smells. Did you guys both miss that? There are 166 code smells currently.
There are a bunch of Sonar failures. Part of that is because there are slight differences between the ruleset in our local Sonar instance and the cloud version. We can tweak the rules if we want, but please take a look at the failures first. If you have a rule you think should be changed, let me know.
There is a badge link to the Sonarcloud failures or you can use this URL:
Adding @depryf for last comment.
I didn't close any issue. I guess it auto-closed when I merge the pull request? The changes looked good, and so I merged it. I didn't realize it wasn't all the fixes.
@bekeles what's the status of this issue now that we have merged multiple pull requests? Do you still have some things to address? I assume so since it looks like the build is still failing...
Yeap, I am still working on them.
Thanks. Just wanted to confirm.
Getting close! Looks like the only issue is a bit of code duplication. I know you already fixed some, hopefully you can do a bit more and go under that 4% threshold. Personally I don't think this is super important, but it would be nice to make the build pass with the standard Sonarcloud setup...
I would not spend a lot of time on code duplication unless it is straightforward.
Wait, are committing directory to master? That should never be done.
No we are not.
What I don't understand is why it is failing now? The duplication was at 20.7% when we started. Is that because it is checking the new code?
Yes, the branches only check new code.
Yeah but master is failing when we merge
The failures on on recent code, not overall. You changed a bunch of lines that included lines that had duplication.
However master still has 55 code smells. I thought you were cleaning them up?
https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=imsweb_mph
Yeap I am. Code smell went down from 170. Those left are low priority and most of them will be fixed in my next merge.
Darn, I was also looking at the recent change instead of overall.
Let's fix the code smells and see where we are at.
Code smells are cleaned! Duplications are down to 12.5%. Are we good?
Yup, sounds good.
Great!
I never saw a pull request. Did it already get done?
Yes, I merged a bunch of them (Sewbesew preferred to split the work into different requests).
Yeap, I have been creating a PR and Fabian was merging them one by one.
In #108 I switched the project integration builds from Teamcity to Github Actions and also switched to Sonarcloud (with pull requests scans integrated). There are a few things that need to be cleaned up with the code.
Spotbugs was set to not fail the build and there are some failure. Please switch the
build.gradle
to fail when the are Spotbugs violations. Here are the failures that need to be fixed.There are a bunch of Sonar failures. Part of that is because there are slight differences between the ruleset in our local Sonar instance and the cloud version. We can tweak the rules if we want, but please take a look at the failures first. If you have a rule you think should be changed, let me know.
There is a badge link to the Sonarcloud failures or you can use this URL:
https://sonarcloud.io/summary/overall?id=imsweb_mph
Assigning to @bekeles and notifying @depryf