search

imsweb / mph

Java implementation of the Multiple Primary and Histology Coding Rules.
Other
4 stars 2 forks source link

Provider last fix #122

Closed bekeles closed 1 year ago

depryf commented 1 year ago

@bekeles the check failed because of code duplication in your new additions. Can you confirm it was like that already and you didn't really make anything worse with your changes?

bekeles commented 1 year ago

No I didn't make anything worse. The after merge duplication rate is still at 12.5%

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.0% 62.0% Coverage
18.9% 18.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

depryf commented 1 year ago

I like these changes much better! Merging now.