search

imsweb / mph

Java implementation of the Multiple Primary and Histology Coding Rules.
Other
4 stars 2 forks source link

Changed MphUtils.getAllGroups() to return a map of ID and MphGroup. … #30

Closed halla-ims closed 6 years ago

halla-ims commented 6 years ago

…Added unit tests. MphGroup names changed from "Year Name" to "Name (Year)". (#23)

Side question: In the file MphConstants.java, the Map MALIGNANT_BRAIN_2007_CHART1 has duplicate key values of: content.put("9392", "Embryonal tumors"); //Ependymoblastoma content.put("9392", "Ependymal tumors"); //Anasplastic ependymoma Does this need to be fixed?

bekeles commented 6 years ago

In the file MphConstants.java, the Map MALIGNANT_BRAIN_2007_CHART1 has duplicate key values of: content.put("9392", "Embryonal tumors"); //Ependymoblastoma content.put("9392", "Ependymal tumors"); //Anasplastic ependymoma Does this need to be fixed?

This one is actually a bug. 9392 exists on both branches. So it should be same primary with both Embryonal tumors and Ependymal tumors. I will assign another issue for that.