search

imtumbleweed / primary

36 stars 42 forks source link

[Enhancements] Else block is not really required. #16

Closed sanjaypradeep closed 5 years ago

sanjaypradeep commented 5 years ago

https://github.com/javascriptteacher/primary/blob/de971b0452b35e1460fc1d59a06351f1a8e6701e/index.js#L43

sanjaypradeep commented 5 years ago

Here's the PR - https://github.com/javascriptteacher/primary/pull/17

adinalini commented 5 years ago

This is a nice intro to PRs :)

imtumbleweed commented 5 years ago

Please don't create issues for things that are not in Trello.

sanjaypradeep commented 5 years ago

Sure @javascriptteacher I'll put in Slack then here after.