Container Responsiveness

imubarak234 / Portfolio-version

The code so far includes a simple layout of the Desktop and mobile versions of my portfolio. This includes a header, welcome note, and completed projects section, and contact form. Some photos were displayed to give more life to the website. Built with HTML, CSS and Javascript

0 stars 0 forks source link

Container Responsiveness #14

Open KayLemba opened 2 years ago

KayLemba commented 2 years ago

Hello Mubarak ,  Everything looks great. Just a few suggestions that could help you improve your code. 😄 Good points

App is runnings as intended
Descriptive README.
No Linter Errors
Code is clean 👍🏿

[OPTIONAL CHANGES]

Please kindly change the font colour and font size for the form validation error message. Do this to make your work look neat and clean.
Kindly make your web page more responsive in order for app to work properly on different screen dimensions.

Happy coding, Cheers!!

Ewoskyx commented 2 years ago

Hello Mubarak, it looks good. There is nothing to add to the comments of @KayLemba for me.

Have fun :)

akucintavalent commented 2 years ago

Hey there Mubarak. I have found a few issues at your main branch:

Whenever I open a project modal window I have to scroll up until I see the window.
After I close the modal window, your entire padding-left seems to become 0.
Your form seems to not be able to send the data.
Your form doesn't check for lowercase in email.
Your last "see project button" doesn't work in the desktop version.
Your form doesn't have a name input field in the mobile version.

I might have not understood some of the problems properly but these are my observations