imuchnik / gource

Automatically exported from code.google.com/p/gource
0 stars 0 forks source link

Problem with --output-custom-log and Bazaar #120

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. bzr branch lp:~ltsp-upstream/ltsp/ltsp-trunk
2. gource --output-custom-log broken.log ltsp-trunk 
3. wc -l broken.log

What is the expected output? What do you see instead?

The log file should list ~1815 lines, instead of 302.

What version of the product are you using? On what operating system?

Gource v0.31 on OSX.

Please provide any additional information below.

The custom log for the said bazaar repository is broken, as it is missing many 
commits. The last in the log is dated in 2005 while the repository has been 
active to current day.

Gource can play the repository history all right, but when it is asked to 
generate a custom log, it fails to dump most commits to the log file.

Original issue reported on code.google.com by mikael.l...@gmail.com on 2 Apr 2011 at 11:33

GoogleCodeExporter commented 8 years ago
Oops, sorry for forgetting the title.
I can't find an edit function..
It should have been "Problem with --output-custom-log and Bazaar"..

Original comment by mikael.l...@gmail.com on 2 Apr 2011 at 11:35

GoogleCodeExporter commented 8 years ago

Original comment by acaudw...@gmail.com on 4 Apr 2011 at 8:35

GoogleCodeExporter commented 8 years ago
Hi.

Part of the problem was --output-custom-log stopped on the first entry it 
couldn't parse. I'll changed it to use the same brute force parsing approach 
Gource uses in normal operation.

The other issue it was unable to parse the commits with '[merge]' after the 
date. I think it's probably just appropriate to allow these. 

Also having a look at other bzr logs, there is sometimes '{tag}' or even '{tag} 
[merge]', so I'll change it to allow for these too.

Does this sound about right?

Cheers

Andrew C

Original comment by acaudw...@gmail.com on 4 Apr 2011 at 10:24

GoogleCodeExporter commented 8 years ago
My attempt at fixing this is in the development version.

Original comment by acaudw...@gmail.com on 5 Apr 2011 at 1:59

GoogleCodeExporter commented 8 years ago
Great, thanks. :) Looks like it works as expected right now, except for the 
minor detail that some entries in the log file are duplicated.

From the same repo that produced 302 lines with version 0.31, the log file 
produced by git master now is 9416 lines, 

 $ wc -l out.log
    9416

but there are some duplicates..

 $ sort out.log | uniq | wc -l
    7525

Thank you for the fix, I can now produce a video for a friend of mine who is 
interested to see the combined activity from all repositories within this 
project. I needed the log files to use the solution presented in issue #8..

Original comment by mikael.l...@gmail.com on 5 Apr 2011 at 11:37

GoogleCodeExporter commented 8 years ago
Well, that is partly to do with bzr commit log entries only having the date and 
no time, so multiple edits to a file on one day by the same user will appear to 
be dups to uniq.

There is also some duplication in another sense because the person doing a 
merge is shown to 'touch' all the files they merged. Really Gource should have 
some way of indicating merges. Perhaps by giving those actions a 'merge' 
attribute and drawing the beams purple or something.

Original comment by acaudw...@gmail.com on 5 Apr 2011 at 9:51

GoogleCodeExporter commented 8 years ago
This change is in the current release 0.34-rc1.

Original comment by acaudw...@gmail.com on 2 May 2011 at 8:29

GoogleCodeExporter commented 8 years ago
I don't get it, "bzr log" gives me dates with granularity up to seconds, so why 
does --output-custom-log only recognize the day?

Original comment by der.ere...@gmail.com on 29 Jul 2011 at 5:42

GoogleCodeExporter commented 8 years ago
It seems the bzr log '--short' format only gives you the date, which is what 
the contributed bzr Gource module was implemented using.

Original comment by acaudw...@gmail.com on 29 Jul 2011 at 10:23