imurvai / brickcontroller2

Cross platform application for controlling Lego creations using a bluetooth gamepad.
108 stars 32 forks source link

Read generic GATT info: model number and firmware revision for Buwizz2 #22

Closed vicocz closed 5 years ago

vicocz commented 5 years ago

Applied your recent changes (truly copied from SBrickDevice code base) so as both firmware and model info are read from well known GATT characteristics: FirmwareRevisionString and ModelNumberString. Additionally it might help to grab device info in case of any Buwizz2 bugs, e.g. as in question #20

imurvai commented 5 years ago

Thanks for this change. I don't have any Buwizz2, so can't try it :) I'll apply it to Buwizz1 too.

vicocz commented 5 years ago

You're welcome. I rechecked it for Buwizz2 having your master branche merged just to make sure it works. If you need anytime to recheck your changes for Buwizz2, just let me know :)

imurvai commented 5 years ago

Cool, actually I wanted to ask you to check the master on your BuWizz2 :) So thanks for re-testing it.