search

imurvai / brickcontroller2

Cross platform application for controlling Lego creations using a bluetooth gamepad.
108 stars 32 forks source link

Prevent crashes when Xamarin Forms 4.4 for UWP is used #30

Closed vicocz closed 4 years ago

vicocz commented 4 years ago

Hi, seems the recent update to Xamarin Forms 4.4 caused crashes in my experimental version of BrickController for UWP platform. I've reported bug https://github.com/xamarin/Xamarin.Forms/issues/9002, but when I see the number of issues, it's easier to apply a workaround here in your app. It's quite simply, passing sourceAssembly parameter for ImageSource.FromResource to prevent crashes when Xamarin Forms 4.4 for UWP is used. Please consider to apply it even it does not affect neither Android nor iOS.

imurvai commented 4 years ago

Hi, ok, I'll look into your PR, however I have limited time these days.