search

imwithye / flask-inject

A micro dependency injection framwork for Flask micro web framework :)
13 stars 5 forks source link

Python 3 changes are not deployed #3

Open GenesisCoast opened 5 years ago

GenesisCoast commented 5 years ago

When trying to use the libary with python 3 I recieve the following error:

'dict' object has no attribute 'iteritems'

After looking through it appears that changes have already been made in the commit d2696616e7df55ae9c10032d655ddf7b2e31bcd0 to support Python3, but are yet to be deployed.

It seems that the package needs to be re-uploaded to PyPi to enable support for Python3. @imwithye would you be able to do this?

imwithye commented 5 years ago

This is great! Sorry I didn't maintain this repo for a while. Could you send a pull request and I will merge and upload to Pypi.

On Fri, Aug 23, 2019 at 5:41 PM Harry Sanderson notifications@github.com wrote:

When trying to use the libary with python 3 I recieve the following error:

'dict' object has no attribute 'iteritems'

After looking through it appears that changes have been made to the 'flask_inject.py' file to at line 19 to enable compatibility with Python3.

I managed to resolve the error, by manually making this change to the package downloaded from PyPi.

It seems that the package needs to be re-uploaded to PyPi to enable support for Python3. @imwithye https://github.com/imwithye would you be able to do this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/imwithye/flask-inject/issues/3?email_source=notifications&email_token=AARPXJEV4R6IRETWTBTERILQF6WEBA5CNFSM4IO5YCBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HG74QEA, or mute the thread https://github.com/notifications/unsubscribe-auth/AARPXJAHKONNDZY4EWHZOKLQF6WEBANCNFSM4IO5YCBA .

GenesisCoast commented 5 years ago

@imwithye The commit d2696616e7df55ae9c10032d655ddf7b2e31bcd0 has already been merged by the pull request #1 it just needs to be uploaded 😊