search

imxiejie / ThinkVim

Vim configuration in the 21st century
MIT License
868 stars 106 forks source link

TSX Support #66

Closed gfsd3v closed 5 years ago

gfsd3v commented 5 years ago

What is your expect?

Maybe it would be good to add TSX support out of the box, I not a heavy vim user and I had a little bit of trouble trying to set this up.

glepnir commented 5 years ago

@gfsd3v i add it support. can you test it?

gfsd3v commented 5 years ago

I get this error while trying to install from the latest commit.

image

nasen23 commented 5 years ago

It's a typo in core/dein/plugins.yaml. There should a space after the on_ft: in line 153.

glepnir commented 5 years ago

Ok, i fixed it. please try agin.

gfsd3v commented 5 years ago

Working great, thanks.

gfsd3v commented 5 years ago

I saw in the coc-settings that we're using TSLint, it maybe be worth it to think about switching to ESLint sense TSLint is being deprecated, what you guys think ?

glepnir commented 5 years ago

Eslint or tslint I think it should be decided by the user, everyone has his own habits, you can make your own custom settings in .thinkvim.d/local_settings.vim.

gfsd3v commented 5 years ago

Sure, I already changed mine, I brought this up only because TSLint is being deprecated, but I guess you will do something about it when it actually is deprecated, thanks for the help and for the awesome repository :)