search

imxieyi / waifu2x-mac

Waifu2x-ios port to macOS, still in Core ML and Metal
MIT License
439 stars 45 forks source link

Outputting Blank Images #3

Closed nikhiljha closed 5 years ago

nikhiljha commented 6 years ago

I did ../waifu2x-mac-cli/waifu2x -t a -s 2 -n 2 -i "$file" -o "output/$file" to upscale some files, but it outputs a blank image at output/$file.

2018-06-23 10:18:15.601 waifu2x[82288:1013507] Maximum texture size supported: 16384
"With Alpha: true"
"Really With Alpha: true"

I tried other image files (jpeg) and they work great, but there seems to be an issue either with transparency or file size. The exact images I was upscaling can be found here: https://drive.google.com/drive/folders/1Ok9QfoeLz0XKYUBOHC5aVq4JWXhzyCas

nikhiljha commented 6 years ago
screen shot 2018-06-23 at 10 21 25 am

The same result in the non-cli version as well.

imxieyi commented 6 years ago

Hi @nikhiljha. I tried the same image as shown on your screenshot but it works fine: image The size of the image is 200x200. It should work fine on any computer. I guess the issue is with Metal. Can you try to comment out this if block and see if it works? Without Metal support the code should be platform-independent, although the performance would suffer from this.

nikhiljha commented 6 years ago

Yup, it works fine without that if block.

nikhiljha commented 6 years ago

I do have a Macbook Pro with a dedicated GPU though, so it probably should work (?)

If not, maybe it should detect the empty image and fallback to non-metal if necessary, it was "only" about 3x slower without metal.

imxieyi commented 5 years ago

This feature has been implemented in the latest version.