Bash script to build project

imxieyi / waifu2x-mac

Waifu2x-ios port to macOS, still in Core ML and Metal

MIT License

445 stars 47 forks source link

Bash script to build project #9

Closed guimondmm closed 5 years ago

guimondmm commented 5 years ago

Pretty self-explanatory. I've added a rudimentary bash script to build the project automatically.

Cleans the base directory of previous build attempts;
Makes Xcode.app the active command line tools provider (required for xcodebuild);
Installs Ruby gem xcodeproj if missing;
Fetches dependencies for the CLI version;
Builds the app with xcodebuild;
Cleans leftover files if the build is successful.

It should help people who download this project but who don't know how to get started with it.

imxieyi commented 5 years ago

Seems fine to me. Does it work on Travis-CI?

Also, could you please update README.md so that people know that this script can simplify build process?

guimondmm commented 5 years ago

I haven't tried it with Travis-CI: it's just my own local build script wIt a few improvements. It could use a little more refining. But I could try to see if I could get it working.

I just noticed that on line 69, the script exits with code 0 even if the build fails. That's a typo: it should read exit 1.

guimondmm commented 5 years ago

Sorry I messed up my repo with a careless git command on the wrong branch. I opened a new pull request, it was easier than trying to undo whatever I've done.