Closed mbroadst closed 8 years ago
@imyller thoughts about the last comment above?
@mbroadst btw. After merge I renamed nodejs.bbclass to nodejs-arch.bbclass because it felt bit too generic to introduce nodejs
class just for internal helper function.
I'll comment on the NPM_*_ARCH in a sec.
@mbroadst
I think this is wrong:
--arch=${NPM_BUILD_ARCH} --target_arch=${NPM_TARGET_ARCH}
--arch
and --target_arch
should match.
@imyller I actually think there's another improvement to be made here. I had initially changed
NPM_ARCH
andNPM_ARCH_NATIVE
innpm.bbclass
toNPM_BUILD_ARCH
andNPM_TARGET_ARCH
respectively.I think when you are running a normal npm you want:
and for native you want:
The only reason I didn't submit this change is because people might already be overriding
NPM_ARCH
andNPM_ARCH_NATIVE