imyller / meta-nodejs

OpenEmbedded layer for latest Node.js releases
MIT License
79 stars 87 forks source link

npm-base: Add support for https proxy #50

Closed raymanfx closed 8 years ago

raymanfx commented 8 years ago

npm was not picking up the environment variable, so we need to pass the flag before calling it.

bachp commented 8 years ago

Could you also implement it for http_proxy

imyller commented 8 years ago

Good point @bachp

Also the native variant should be patched similarly.

Could be done in the context of this PR or separately.

bachp commented 8 years ago

btw we already set some env variables via export. So for consistency reason we should set them all either via export or during the call.

imyller commented 8 years ago

I'd prefer the export method. There is slight difference in export and setting in call:

I'd assume export to stay set even if npm opens new (sub-)shell process while in-call might be limited to npm process itself but might not always propagate to it's sub-shells.

raymanfx commented 8 years ago

Updated:

imyller commented 8 years ago

LGTM