search

in-RET / ramp_gui

MIT License
0 stars 1 forks source link

Add co-author to the initial commit #7

Open Bachibouzouk opened 1 month ago

Bachibouzouk commented 1 month ago

Hello,

Thank you for creating this repository :)

As a lot of the work stems from @SoniBhaveshh (https://github.com/RAMP-project/RAMP/pull/141), I think it would be fair to rebase and edit the commit messages to explicitly mark him as a co-author. Especially now that there are not many commits since the initial one and that few people have been using this repository ( as rebase will change the commit numbers).

To add co-author within the commits: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Bachibouzouk commented 1 month ago

I overlooked the PR https://github.com/in-RET/ramp_gui/pull/6 in which it seems are the changes made by @SoniBhaveshh.

Do you plan to merge them?