search

in-formant / in-formant

software for real-time voice analysis
Apache License 2.0
215 stars 39 forks source link

MacOS 3.1.2 package has no binary or Info.plist #26

Open ellieayla opened 3 years ago

ellieayla commented 3 years ago

Normally Contents/MacOS/InFormant is an executable binary, but is not present in the two 3.1.2 release packages. Also missing is the Contents/Resources/ directory (normally holding qt.conf & qml/), and the Contents/Info.plist file (bundle name/version).

ls InFormant-*.app/Contents/

InFormant-3.0.2-macOS-x86_64.app/Contents:
Frameworks Info.plist MacOS      PlugIns    Resources  # ok

InFormant-3.0.3-macOS-x86_64.app/Contents:
Frameworks Info.plist MacOS      PlugIns    Resources  # ok

InFormant-noml-3.1.1-macOS-x86_64.app/Contents:
Frameworks Info.plist MacOS      PlugIns    Resources  # ok

InFormant-3.1.2-macOS-x86_64.app/Contents:
Frameworks PlugIns  # not ok

InFormant-DF-3.1.2-macOS-x86_64.app/Contents:
Frameworks PlugIns  # not ok

Extracted from these 5 release disk images:

408da8697cf3c8596d31dc37aaa1721ab884d056  InFormant-3.0.2-macOS-x86_64.dmg
8ca6236afc8b6c91f91d075e5773a510a909a2c5  InFormant-3.0.3-macOS-x86_64.dmg
1469a774a4664e71cf500f30ede554da51528814  InFormant-noml-3.1.1-macOS-x86_64.dmg
a91133155a29c6c82f5d3b091964956fdb7d1391  InFormant-3.1.2-macOS-x86_64.dmg
1e621afd76f4dcc4508ac0b486e248b18eb57c12  InFormant-DF-3.1.2-macOS-x86_64.dmg

https://github.com/clo-yunhee/in-formant/compare/3.1.1...3.1.2 isn't small, and the cause isn't obvious. But I don't see a way for deploy-macos.sh to have succeeded like this (esp with set -e).

I didn't see a similar issue report. Not sure if you're already aware of this and/or related to post-3.1.2 work in commit bb7a7aae1ce718c717695ba2f1aea98beeaf29ef.

clo-yunhee commented 3 years ago

Oh what the heck? Thank you for bringing this to my attention, I had no idea the script had broken between those versions.

Holot commented 3 years ago

Fix of this issue will be really helpful. I have 100% CPU load for this program in windows virtual machine (4 cores, i9-9980H), so, native macos app would be great. Thanks.

clo-yunhee commented 3 years ago

There's no reason to use a virtual machine just use Wine.