search

in-op / PokemonGen1

A complete Pokemon generation 1 battle simulator including all Pokemon and moves.
12 stars 2 forks source link

StatExp redundant; use Stats #6

Open in-op opened 6 years ago

in-op commented 6 years ago

All uses of StatExp should be converted to Stats. Both data types are just a set of float fields for HP, Attack, etc. StatExp was mutable with the idea in mind that it would need to be updated after a battle, but was never actually used. If it ever does need to be implemented in the future, it can still be accomplished with the immutable Stats, just overload the + operator. tldr: StatExp: YAGNI