search

in-sideFX / Undecorator

Decorate "Undecorated" JavaFX windows
118 stars 30 forks source link

[Bug] Menubars confuse undecorator #6

Open LiSongMWO opened 10 years ago

LiSongMWO commented 10 years ago

It seems that menubars cause undecorator to barf and fail at determining the correct area to place the decoration: image

The demo projects work as expected. I tried to just swap the fxml file to mine in the demo project and comment out any lines that causes failures at startup. It still renders as above so I believe this to be a bug.

The FXML file that is causing this behavior is here: https://gist.github.com/EmilyBjoerk/1488e748c89be75e8bee

in-sideFX commented 10 years ago

Hi Emily, For your usage, I recommend to add a padding on top of your border pane, and set some minimal sizes on your main content, such as: menubar

The result will be better: menubarresult

Hope this helps, Arno.

LiSongMWO commented 10 years ago

I ended up rolling my own frame decoration based on a border pane. It doesn't need this workaround.

2014-04-29 9:44 GMT+02:00 in-sideFX notifications@github.com:

Hi Emily, For your usage, I recommend to add a padding on top of your border pane, and set some minimal sizes on your main content, such as: [image: menubar]https://cloud.githubusercontent.com/assets/3024670/2826538/fc6e1284-cf71-11e3-8288-b8f2f92a92e9.png

The result will be better: [image: menubarresult]https://cloud.githubusercontent.com/assets/3024670/2826549/05a067a8-cf72-11e3-9b28-46d08e5e1fc5.png

Hope this helps, Arno.

— Reply to this email directly or view it on GitHubhttps://github.com/in-sideFX/Undecorator/issues/6#issuecomment-41649380 .