search

in-tech-gration / WDX-180

Web Development X
GNU General Public License v3.0
12 stars 26 forks source link

Review Week 03 #8

Closed patric94 closed 9 months ago

patric94 commented 9 months ago

Review the content of Week 03

Please make any suggestions for adding/removing content on each day. Please point out any mistake found on any file of Week 03.

Sha-Shak commented 9 months ago

Issue #1 W3-D2

File Path: curriculum/week03/exercises/styling_a_biography_page/README.md Section: Starting Point Description: The URL https://github.com/in-tech-gration/WDX-180/blob/main/curriculum/week03/exercises/styling_a_biography_page/assets/blog-download.html isn't working.

Sha-Shak commented 9 months ago

Issue #2 W3-D2

File Path: curriculum/week03/exercises/styling_a_biography_page/README.md Section: Example Description: Progress Sheet link isn't working.

patric94 commented 9 months ago

Thanks for the info Shariar! Updated the main repo and those issues are fixed.

FYI pogress sheet links are linking to files that the users have to create, so if there is a 404 error when clicking on the link, it's gonna work as a reminder to create such file as per instructions.

If you do not have any more comments, tell me to close this issue! :)

Sha-Shak commented 9 months ago

Welcome 😄 Well, I'm not done yet. Issue #3 W3-D3

File Path:

  • WDX-180/curriculum/week03/resources/css_building_blocks/css_selectors/README.md
  • curriculum/week03/resources/css_building_blocks/css_selectors/type_class_and_id_selectors/README.md

Section:

Description: If I'm understanding it correctly, you want to load the site in the readme. The iframe isn't doing anything. The link works fine but the iframe is just text. Maybe GitHub isn't rendering because of security measures?

patric94 commented 9 months ago

Hello!

Yeah that's a GitHub issue for security measures. In the future we would like to find a way to have live examples displayed properly, in markdown files, on GitHub.