search

in-toto / in-toto.io

The in-toto website and documentation
https://in-toto.io
2 stars 19 forks source link

Add missing predicate spec redirects, update Statement v1 redirect #38

Closed marcelamelara closed 3 months ago

marcelamelara commented 4 months ago

This PR adds redirects for all vetted predicateType URIs (latest versions as of today), and updates the Statement/v1 redirect to point to the v1 directory containing the latest Statement spec, rather than a git tag.

Fixes https://github.com/in-toto/attestation/issues/321 Fixes https://github.com/in-toto/attestation/issues/346

marcelamelara commented 4 months ago

Please note: this PR may need more updates after #23 is merged.

chalin commented 4 months ago

@marcelamelara - #23 has been merged, is this ready to go?

chalin commented 4 months ago

@marcelamelara @JustinCappos - for some context: I'd like to get this merged (once it's ready) so that #43 can be fixed ASAP.

marcelamelara commented 4 months ago

This is ready for review.

lukpueh commented 4 months ago

Interesting... I just fixed netlify integration and pushed a duplicate of this PR (#50) to trigger deploy preview. A link to that same preview was added here and in #50. :)

lukpueh commented 4 months ago

Updating the redirects to match the current URL spec seems like a good idea. Let me know when you want another review.

lukpueh commented 3 months ago

Updating the redirects to match the current URL spec seems like a good idea. Let me know when you want another review.

friendly ping @marcelamelara. Did you want to update the redirects in this PR, or should we merge and fix in a follow-up? I'm fine either way. Just want to know how to move forward to unblock #43.

netlify[bot] commented 3 months ago

Deploy Preview for in-toto ready!

Name Link
Latest commit 8b0e79fc26a367e3bcc5252c37a4d051411f50ce
Latest deploy log https://app.netlify.com/sites/in-toto/deploys/669781f349d1c00008a7f3e8
Deploy Preview https://deploy-preview-38--in-toto.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marcelamelara commented 3 months ago

friendly ping @marcelamelara. Did you want to update the redirects in this PR, or should we merge and fix in a follow-up? I'm fine either way. Just want to know how to move forward to unblock https://github.com/in-toto/in-toto.io/issues/43.

Thanks so much for the ping @lukpueh . I made the outstanding changes, so I think this can be merged now, and we can fix any URLs in a follow-up PR.

lukpueh commented 3 months ago

Thanks for the updates. I allowed myself to rebase and sign off the commit I co-authored, to make the DCO check pass.