search

in-toto / specification

Specification and other related documents.
https://in-toto.io
MIT License
40 stars 26 forks source link

Potential grammatical error #81

Closed ChaosInTheCRD closed 11 months ago

ChaosInTheCRD commented 11 months ago

Hi there 👋

I am just reading through the spec and I noticed a small sentence that might be a grammatical error? I just thought it would be worth raising in case it needed a cleanup. The line in question is L431-L432:

A functionary can allow a third-party define a step or series of steps of the supply chain a sublayout

I was thinking maybe this is meant to read as something like:

A functionary can allow a third-party to define a step or series of steps of the supply chain known as a sublayout

Maybe grammatically the current sentence is technically correct, it just didn't quite read correct to me.

Thanks 😄

JustinCappos commented 11 months ago

I agree this is broken and your fix would correct it. Would you like to submit a PR and we can accept?

adityasaky commented 11 months ago

A functionary can allow a third-party to define a step or series of steps of the supply chain using a sublayout.

I have a suggestion to your proposed text. +1 to Justin's comment, a PR would be great!

ChaosInTheCRD commented 11 months ago

Hi both, I'll go ahead and submit a PR as suggested - thank you for the quick response!

ChaosInTheCRD commented 11 months ago

https://github.com/in-toto/docs/pull/82