search

in-toto / witness

Witness is a pluggable framework for software supply chain risk management. It automates, normalizes, and verifies software artifact provenance.
https://witness.dev
Apache License 2.0
416 stars 60 forks source link

Fixing failed metav1.Time test error for `verify` #315

Closed ChaosInTheCRD closed 1 year ago

ChaosInTheCRD commented 1 year ago

When running make test I noticed that they were failing due to an error caused by the Expires field not accepting time.Time variables. I don't have full context but changing it to the below fixed the tests. Worth getting eyes from someone responsible for these tests in the past for sanity 😅.

colek42 commented 1 year ago

cc @jkjell I think this was introduced when you make the changes for the data provider.

mikhailswift commented 1 year ago

Strange part is I seem to remember fixing this at one point 🤔 . Guess I either imagined that or never got it into main.

ChaosInTheCRD commented 1 year ago

Ah. I see why this is a problem.

I am replacing go-witness in my go.mod with my local module. This was causing the error above with tests. Of course, this repository follows version 1.17 of go-witness, which still has this field as type time.Time.

This will need to be fixed eventually, but not yet.