in-toto / witness

Witness is a pluggable framework for software supply chain risk management. It automates, normalizes, and verifies software artifact provenance.
https://witness.dev
Apache License 2.0
415 stars 59 forks source link

fix: repetitive and incorrect log lines on witness verify #317 #485

Open ChaosInTheCRD opened 3 months ago

ChaosInTheCRD commented 3 months ago

What this PR does / why we need it

some cleanup around https://github.com/in-toto/go-witness/pull/317.

testing instructions for @Xopek from https://github.com/in-toto/go-witness/issues/316:

go 1.22.0

toolchain go1.22.2

++ replace github.com/in-toto/go-witness => <path/to/local/go-witness>


- run `go mod tidy`
- test with `go run . run` and `go run . verify` in the root of this branch.
netlify[bot] commented 3 months ago

Deploy Preview for witness-project ready!

Name Link
Latest commit d91794bfa49b8d08d2031f2da55435f9e7c4d4af
Latest deploy log https://app.netlify.com/sites/witness-project/deploys/66abb31fb9ca7a0008db8ca8
Deploy Preview https://deploy-preview-485--witness-project.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Xopek commented 3 months ago

Can confirm, that this fixed issue https://github.com/in-toto/go-witness/issues/316.

However for some reason in order for "verify" command to work, i had to regenerate attestations, without it verify failed with error:

ERROR   Verification failed
ERROR   Evidence:
ERROR   Step: build
ERROR   verification failure: no collections found
ERROR   failed to verify policy: policy verification failed