in03 / proxima

Transcode source media directly from DaVinci Resolve using multiple machines for encoding. Great for creating proxies quickly.
MIT License
50 stars 3 forks source link

Wildcard matching is too broad when matching linkable existing proxies #215

Closed in03 closed 1 year ago

in03 commented 2 years ago

Problem

It's cool that these are matching by newest. That's definitely handy. But so far Proxima overwrites originals anyway. Currently this feature exists just to support Resolve's internally generated method which appends digits. In future, we can add support for incrementing files on collision.

Pasted image 20220818122051

Pasted image 20220818122359

What isn't working is the wildcard match. One of the source files is "Cockburn Drone.mov" Since we're just checking the title starts with "Cockburn Drone" it also matches:

If they all exist in the same source folder, they'll be candidates for "Cockburn Drone.mov". This doesn't work in reverse though since "Cockburn Drone" doesn't contain "Cockburn Drone - ARC - STBLSD".

Solution

We could filter linkable matches with regex in user config. Then we could have Resolve's _S000 suffix pattern as a default option as well as maybe - 1 or _1 with varying whitespaces out of the box. Regex would be easiest since it's so flexible and we can make it faster by only running the regex match on initial matches that contain the original filename like we're already doing.

in03 commented 1 year ago

Fixed by #234