search

in0finite / SanAndreasUnity

Open source reimplementation of GTA San Andreas game engine in Unity
https://discord.gg/p6jjud5
MIT License
2.15k stars 353 forks source link

How to integrate GXT parser into this project? #22

Closed lexnewgate closed 5 years ago

lexnewgate commented 5 years ago

Hi, I have finished initial version of SanAndreasGXTParser. Check here.

  1. But how can I integrate this into the project? Would you please offer some help? Perhaps some interface or folder where I should integrate this ?

  2. And I also don't know what code style should I follow? (naming, comments, etc)

  3. About code. Should we consider efficiency from start? Or we just do what we like and then profile?

in0finite commented 5 years ago

Nice job.

  1. All importing code should go to Assets/Scripts/Importing/. So you can create new folder in there (for example, GXT), and copy your .cs file in there. Then, you can make a new window to display gxt data in game (I can do this if it's difficult for you).
  2. Code style is not so important right now. Use whatever you like. As long as it's displayed nicely in VSCode :D.
  3. Performance is very important, especially because it is loaded from disk. It should be as fast as possible. But, since we are not using gxt yet, it doesn't really matter right now.
lexnewgate commented 5 years ago

image About the window, do you mean something like this?

in0finite commented 5 years ago

Yes. It's very easy to do it. Take a look at existing windows, like StartGameWindow. All you have to do, is to inherit a class, override a method, and then add your window script to UI prefab.

lexnewgate commented 5 years ago

All right. Thanks a lot. I will try it.