Issues on case-sensitive file systems

echozio commented 5 years ago

Running the game on Linux with EXT4 and the Steam version of the game, I encounter a lot of errors with files the game is unable to locate due to the case in the path being different. For instance the "Data" directory has a capital D where as the game looks for "data". I've had to work around this by creating a disk image with FAT32 and copying the game data there. The code should perhaps be updated to ignore case when looking for files.

in0finite commented 5 years ago

That's what I explained in instruction for Linux.

The code should perhaps be updated to ignore case when looking for files.

There is no C# API for opening files case-insensitively (maybe not even a Linux API). But we could enumerate all files in GTA installation, store them in some list, and then search through this list case-insensitively (this is the best solution).

Also, there are some other solutions for this:

identify which files have wrong name, and create a script which will rename them
someone told me that there is a new feature in linux kernel 5.2, which allows to make any EXT4 directory case-insensitive

echozio commented 5 years ago

I'm sorry, I completely missed those instructions.

There is no C# API for opening files case-insensitively (maybe not even a Linux API).

Yes, I realize you would need additional logic to be able to do this, but at least in the future it should be implemented in the application to eliminate manual steps that need to be taken by less technical users. Certainly not something that matters much in practice right now, I'm sure.

Enumerating the files and comparing case-insensitively like you said definitely seems like the best long-term solution.

I'm on kernel 5.3, so I tried giving this a shot, but it turns out the EXT4 filesystem requires an additional attribute, encoding=utf8, in order to do this. For those who can use it, though, this is by far the easiest solution (in contrast to renaming or using a FAT image).

All you have to do on a compatible system is to go to your San Andreas directory and run

chattr +F .

in0finite commented 5 years ago

in the future it should be implemented in the application to eliminate manual steps that need to be taken by less technical users.

I agree. It should run out of the box with no additional setup. It's just that there hasn't been many Linux users so far, so this wasn't a problem.

it turns out the EXT4 filesystem requires an additional attribute, encoding=utf8, in order to do this

So this attribute is specified at moment of creation of EXT4 partition, or can be changed later ? If it can be changed, than that is the way to go.

echozio commented 5 years ago

So this attribute is specified at moment of creation of EXT4 partition, or can be changed later ? If it can be changed, than that is the way to go.

Unfortunately not. I did give it a shot with tune2fs /dev/sdb1 -E encoding=utf8, however only a subset of extended options are possible to change on an existing filesystem.

slapin commented 5 years ago

I think the best solution (and easiest to implement one) would be to try open all used GTA files to check for proper naming and report user to rename these. For long term solution I think just lowercasing all filenames open from dat files will do. User could use one of lowercase scripts once on their GTA installation. I think lowercasing is very quick to add and that will solve the problem completely and no fancy stuff will be required.

slapin commented 5 years ago

To rename all files, go to gta sa directory and run the following script:

rename -v 'y/A-Z/a-z/' `find .`

if errors are printed, run it again until no output given

To make game work with lowercase files, the small patch is needed:

diff --git a/Assets/Scripts/Importing/Items/Item.cs b/Assets/Scripts/Importing/Items/Item.cs
index 03012128..85009767 100644
--- a/Assets/Scripts/Importing/Items/Item.cs
+++ b/Assets/Scripts/Importing/Items/Item.cs
@@ -40,6 +40,7 @@ namespace SanAndreasUnity.Importing.Items
                     args = args.Replace(".IDE", ".ide");
                     args = args.Replace(".IPL", ".ipl");
                     args = args.Replace('\\', Path.DirectorySeparatorChar);
+                   args = args.ToLower();

                     switch (type.ToLower())
                     {

Thanks for the nice project. Very nice playground. Is it possible to enter cars yet or see peds actually dying (not disappearing)?

in0finite commented 5 years ago

@slapin Thanks for suggesting another solution.

But I don't agree that it is the best long-term solution. The best solution would be to case-insensitively search for files in internal list of all files, like I said before. This will not require any setup from users.

I think I know how to do it. ArchiveManager holds all loaded archives. One of them is LooseArchive, which is actually a directory, and contains files from GTA installation. So what we can do, is to replace arg with the real name, after this line:

https://github.com/GTA-ASM/SanAndreasUnity/blob/7725dfbf7130a061c7adf6f25f3b735192572c84/Assets/Scripts/Importing/Items/Item.cs#L42

The real name will be retreived from ArchiveManager.

Thanks for the nice project. Very nice playground.

Yeah, it's just fun to work on it :grinning:

Is it possible to enter cars yet

Well, did you see gameplay video, or even played the game ? Of course it is.

see peds actually dying (not disappearing)?

Not yet.

echozio commented 5 years ago

I completely agree with @in0finite . This also allows you to use an existing game installation without altering it.

I haven't read enough of the code to have any valuable input on your suggested implementation, but if you implement it I would be happy to test it.

in0finite commented 5 years ago

It shouldn't be difficult. But I'm a little busy these days, so you guys can give it a try in the meantime.