radio

[jaan242]

Implemented playing radio stations in vehicles. Sounds are played in the order they are stored in files. Only driver ped can change station using the same buttons which are used for switching weapons (E and Q on a PC, arrows at bottom of screen when using touch input). Selected radio station is not currently synced between players.

[in0finite]

• GameManager should not have anything with radio
• Vehicles.Radio should not be singleton component. Actually, it can be completely removed. All radio-related code should be in Vehicle_Radio.cs.
• Every vehicle should have it's own AudioSource component for playing radio. This way, you can play multiple radios at the same time, which is good if we want to hear radio sound in 3d.
• Don't use m_ped == Ped.Instance, but use m_ped.IsControlledByLocalPlayer
• You should not use AudioManager.PlayStream() which creates new game object every time, but instead use AudioManager.CreateAudioClipFromStream() and assign the created clip to AudioSource. Also, destroy this clip after it's finished playing, or otherwise you will have memory leak.
• ~Problem with radio stations is that sounds are not in correct order, and that there are many intros and outros to a single song. So you can't just play them in the order they are stored. But for now, let's leave it like this.~ - this is already explained in #29
• ~You didn't understand what I meant regarding touch input. You don't have to change it. It already has buttons for switching to next/previous weapon, which can be used to switch radio stations when in vehicle. So, revert changes to TouchInput.cs and UI.prefab.~
• Starting/stopping radio : I think it's better to do this from Vehicle.Update(), because if ped dies, noone will turn off radio.

[jaan242]

Driver has different touch input, so no changes there, but improved other things.

[in0finite]

So, GameManager.prefab can be reverted now ?

[jaan242]

Reverted GameManager.prefab Added not null check to Ped.Instance Radio station and time randomized in Vehicle.Start

[in0finite]

Let me tell you how I imagined radio station times. Each vehicle has it's own active station. But, stations in all vehicles have the same current time (song and song's time). So, if ped changes vehicles, and plays the same station, he should hear the same song.

With your setup, each vehicle has it's own current time for station. Plus, all stations have the same current position. It should not be like this. It should mimic the real world.

[jaan242]

Radio station playback position is kept across vehicles and station switches.

[in0finite]

Ok. Will test this tomorrow.