Open ulrike-cosmoblonde opened 1 year ago
I think this is already fixed with https://github.com/in2code-de/femanager/pull/480/files
By looking at the fix I can only see my 2nd suggested change implemented (changing the && into an ||). But my 1st and 3rd remarks are not implemented. As far as I can see, the string 'edit/email/createUserNotify/notifyAdmin/receiver/email/value' is not valid as the 'createUserNotify' should not be contained and the getValue function is still missing a 2nd parameter which is required.
You're right please have a look at https://github.com/in2code-de/femanager/pull/496 and confirm if your tests were successful.
This issue is related to #472
In my example I experienced the problem for the "edit" function. The notifyAdmin is not working due to the changes in: public/typo3conf/ext/femanager/Classes/Controller/AbstractController.php => updateAllConfirmed and in public/typo3conf/ext/femanager/Classes/Utility/ConfigurationUtility.php
The following problems exist:
In both files the string 'edit/email/createUserNotify/notifyAdmin/receiver/email/value' should be changed into: 'edit/email/createUserNotify/notifyAdmin/receiver/email/value' I believe the /createUserNotify/ part was falsly added.
The function ConfigurationUtility::notifyAdminAboutEdits should have an OR condition instead of an AND condition
The function updateAllConfirmed in the AbstractController is missing a 2nd parameter in the ConfigurationUtility::getValue function calls
With those 3 adjustments the notifyAdmin should work as expected for updates.
Regards! Ulrike