search

in2code-de / femanager

Modern TYPO3 Frontend User RegistrationTYPO3 Frontend User Registration and Management based on Extbase and Fluid and on TYPO3 8 and the possibility to extend it to your needs. Extension basicly works like sr_feuser_register
https://www.in2code.de/agentur/typo3-extensions/femanager/
48 stars 118 forks source link

Confirmation link can be clicked multiple times #559

Closed mhuber84 closed 1 week ago

mhuber84 commented 5 months ago

If the user clicks the link in the confirmation email multiple times, the finishers get executed every time. But they should get executed only once.

A return true; in the if ($user->getTxFemanagerConfirmedbyuser()) in NewController::statusUserConfirmation() helps. Can someony confirm this?

Edit: Removed "but then the userConfirmationRedirect is not executed anymore"

epxfrho commented 5 months ago

I can confirm that issue and the return true; workaround. Similar problem in if ($user->getTxFemanagerConfirmedbyadmin()) in NewController::statusAdminConfirmation().

However, I do not find it necessary to redirect to the newAction at this point. The user clicks on the confirmation link several times, so he/she has an account, why show the form?

akiessling commented 4 months ago

Can confirm the issue, return true; works. The redirect should be dropped, i don't see the usecase for that either.

mhuber84 commented 3 months ago

Are there any news on this issue?

hannesbochmann commented 1 month ago

I ran into this problem, too. A simple return true; is not enough. The redirect response object needs to be returned and used in the actual action.

hannesbochmann commented 1 month ago

The same problem exists for other actions as well. I provided a PR which fixes a redirects.