in2code-de / femanager

Modern TYPO3 Frontend User RegistrationTYPO3 Frontend User Registration and Management based on Extbase and Fluid and on TYPO3 (version 8 or newer) and the possibility to extend it to your needs.
https://www.in2code.de/agentur/typo3-extensions/femanager/
48 stars 118 forks source link

TypoScript setting removeFromUserGroupSelection not working anymore in v8 #591

Closed Patta closed 1 week ago

Patta commented 3 weeks ago

TYPO3 12.4.22 PHP 8.2 femanager 8.2.0

The TypoScript setting plugin.tx_femanager.settings.new.misc.removeFromUserGroupSelection = 23,42 is not working anymore in v8.2.0. All usergroups are inserted in the usergroup select field.

zobnov commented 3 weeks ago

+1 I have this issue as well.

Patta commented 3 weeks ago

The problem seems that the controller name is not properly set in https://github.com/in2code-de/femanager/blob/07228e30b9c18cfba5351d8f535333338216b3b2/Classes/Controller/AbstractController.php#L617

If we set the controller name for the registration plugin like $controllerName = 'new'; the TypoScript setting removeFromUserGroupSelection is working.

zobnov commented 3 weeks ago

@Patta can you submit a pull request so this will get fixed for everyone, please? Everyone will be grateful to you, thanks!

Patta commented 3 weeks ago

@zobnov hard coding of the controller name to "new" in AbstractController would then only work as workaround for the usergroup field in the registration form. the getControllerName function in In2code\Femanager\Utility\FrontendUtility needs instead to be updated/migrated.

https://github.com/in2code-de/femanager/blob/07228e30b9c18cfba5351d8f535333338216b3b2/Classes/Utility/FrontendUtility.php#L108