in2code-de / femanager

Modern TYPO3 Frontend User RegistrationTYPO3 Frontend User Registration and Management based on Extbase and Fluid and on TYPO3 (version 8 or newer) and the possibility to extend it to your needs.
https://www.in2code.de/agentur/typo3-extensions/femanager/
48 stars 118 forks source link

Wrong order action in ResendConfirmationMail plugin #617

Open klodeckl opened 5 days ago

klodeckl commented 5 days ago

Hello,

the resend confirmation mail plugin is broken because of the wrong order in \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin in ext_localconf.php

It is:

    \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
        'Femanager',
        'ResendConfirmationMail',
        [
            \In2code\Femanager\Controller\NewController::class => 'confirmCreateRequest, createStatus, resendConfirmationMail, resendConfirmationDialogue',
        ],
        [
            \In2code\Femanager\Controller\NewController::class => 'confirmCreateRequest, createStatus, resendConfirmationMail, resendConfirmationDialogue',
        ],
        \TYPO3\CMS\Extbase\Utility\ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT
    );

But it should be:

    \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
        'Femanager',
        'ResendConfirmationMail',
        [
            \In2code\Femanager\Controller\NewController::class => 'resendConfirmationDialogue, confirmCreateRequest, createStatus, resendConfirmationMail',
        ],
        [
            \In2code\Femanager\Controller\NewController::class => 'resendConfirmationDialogue, confirmCreateRequest, createStatus, resendConfirmationMail',
        ],
        \TYPO3\CMS\Extbase\Utility\ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT
    );

Otherwise the wrong action (confirmCreateRequest) is called.

sbusemann commented 5 days ago

Which version?

klodeckl commented 5 days ago

Version is current main branch here. TYPO3 12.4.23

sbusemann commented 5 days ago

confirmed with 8.2.1

sbusemann commented 5 days ago

todos: