in2code-de / in2publish_core

in2publish Community Version

https://www.in2code.de/produkte/content-publisher/

GNU General Public License v3.0

40 stars 23 forks source link

[BUGFIX] Replace splat operator on associative arrays #110

Closed YKWeyer closed 9 months ago

YKWeyer commented 11 months ago

Issue

Fixes https://github.com/in2code-de/in2publish_core/issues/109

Changes

Each parameter is specifically set, instead of relying of the splat operator (...)
It removes the need to unset some of the $data array values
When the class is not known, I used array_values for versions < 8.1 as a fallback

I tried to identify as much occurrences as possible, but I might have missed some.

vertexvaar commented 9 months ago

Sorry, i haven't noticed this PR until today but already fixed parts of it yesterday. I would've merged it though :sweat_smile: :pray:

YKWeyer commented 9 months ago

Hahaha no problem, glad to see we both ended up with a similar fix! Should I specifically tag you the next time I open an issue or a MR?

Looking forward to the 12.4.1 release so I can get rid of my custom patches :wink:

vertexvaar commented 9 months ago

I think it might be more effective to announce new issues/PRs in the #ext-in2publish Slack channel and mention the product owner @sbusemann or other developers like @dhoffmann1979 or @tinzog there. I'm temporarily in another team (in in2code GmbH), so i'm currently not the go-to person for that kind of stuff.