search

in2code-de / in2publish_core

in2publish Community Version
https://www.in2code.de/produkte/content-publisher/
GNU General Public License v3.0
40 stars 23 forks source link

File transfer fails for a new (not on foreign system) file used in a CE #25

Closed AndreasA closed 7 years ago

AndreasA commented 7 years ago

Steps to reproduce: 1.) Add new file to fileadmin 2.) Reference that file in a content element. 3.) Publish the page that references the new file.

Result: Everything has been transfered except the new file. Instead there is only an empty dummy file. However, the asset publisher also shows further changes. After completing another publish the file is correctly transfered.

Not sure if this is intended or not.

vertexvaar commented 7 years ago

Hi @AndreasA ,

I identified a problem with theSshConnection::setCreateMask that persisted the switch to the RCE API. I'm fixing this right now, but it might not directly affect your specific problem. Are there any log entries that might help? The Tools module should help you to identify such log entries when you limit the log level to 4 or less. (If you can not limit to 4 or less then there is no log entry with that severity)

AndreasA commented 7 years ago

When publishing a file it fails with an exception because the response doesn't find the FileCreateMask although the entry is there (is even the exception) but I think there is an invisible UTF-8 character before it. It will proabably be the same issue with the SshConnection::setRemoteFilePermission and SshConnection:createRemoteFolder::createRemoteFolder if setPermissionPerCommand is used.

But as long as executeRemoteCommand is fixed all of those instances should be fixed.

For details I will have to check at work.

vertexvaar commented 7 years ago

Hi @AndreasA

so the reason is probably the problem mentioned in #26 which i already identified (but did post way later than you). I'll push the patch in a minute (i'm currently testing the changes).

AndreasA commented 7 years ago

Great. I will test it tomorrow and let you know.

AndreasA commented 7 years ago

Ah sorry. My fault. I thought I was in another ticket. No the issue is the following but maybe it will be fixed with #26 too.

The issue was just that the file was created but the content wasn't transfered. However, with a second publish it worked, so I am not sure if it is really #26 but I will test it again tomorrow with the change from #26.

AndreasA commented 7 years ago

Added a comment in https://github.com/in2code-de/in2publish_core/issues/26 I think there are still two instances where RCE API should be used.

AndreasA commented 7 years ago

This seems to work now. I am closing the issue. I think it might also have been because the sys_file table was not up-to-date on both systems which resulted in UIDs being re-used..