in2code-de / in2publish_core

in2publish Community Version
https://www.in2code.de/produkte/content-publisher/
GNU General Public License v3.0
40 stars 23 forks source link

DB test fails when port is not 3306 #48

Closed YKWeyer closed 5 years ago

YKWeyer commented 6 years ago

When using a port other than 3306 to access foreign database, the tests view returns

One or more options are not confiured correctly. [foreign.database.hostname]: The host [HOST] is not reachable: Host is unreachable

This error probably results of the CoreDefiner testing the foreign database hostname on port 3306 (hardcoded): https://github.com/in2code-de/in2publish_core/blob/55bfcb076eabb4c2a8dae8b4cda4194e3a33875a/Classes/Config/Definer/In2publishCoreDefiner.php#L147

Possible fixes

The test should retrieve the port value from the custom configuration, or be defined as non-blocking for other tests to run

sbusemann commented 6 years ago

https://projekte.in2code.de/issues/32520

vertexvaar commented 5 years ago

Hi @YKWeyer,

the HostNameValidator has been removed by @sbusemann, as it will be tested with the actual port in the DatabaseConnectionTest. Thank you for your report :+1: