in2code-de / luxletter

Newsletter system for TYPO3
https://www.in2code.de/agentur/typo3-extensions/luxletter/
23 stars 25 forks source link

Error after update from Update 17.3.0 to 19.0.0 #166

Closed alexingo closed 1 year ago

alexingo commented 1 year ago

Hi! I'm using Typo3 11.5.21 and php8 After update I get this error for preview:

503 Oops, an error occurred! Required argument "origin" is not set for In2code\Luxletter\Controller\FrontendController->preview.

I've checked the documentation. Maybe I've oversseen some new settings!?

Thanks for any advice! Inge

einpraegsam commented 1 year ago

Do you use the multilanguage feature in LUXletter? What origin is used? The failure is visible in the preview of the newsletter?

alexingo commented 1 year ago

the site is multilanguage, but the newsletter actually only one Language - yes, it's the newsletter preview!

einpraegsam commented 1 year ago

I just double checked the functionality on my test machine but can't reproduce this issue. Can you please inspect the preview iframe and post the src-attribute. It should be something like: //lux.localhost.de?type=1560777975&tx_luxletter_preview[origin]=30&tx_luxletter_preview[layout]=NewsletterContainer&tx_luxletter_preview[language]=0

alexingo commented 1 year ago

site.de?type=1560777975&tx_luxletter_preview[origin]=615&tx_luxletter_preview[layout]=NewsletterContainer&tx_luxletter_preview[language]=0"

einpraegsam commented 1 year ago

Because TYPO3 12 needs to use different plugins for different views now, there was a small change in TypoScript. Can you please disable all your individual TS and test with original settings again?

einpraegsam commented 1 year ago

BTW: Did you see the breaking changes section and followed the instructions? https://github.com/in2code-de/luxletter/blob/develop/Documentation/Changelog/Index.md#upgrade-to-18x

alexingo commented 1 year ago

Actually I've deactivated all typosricpt for testing. I try another update in a single language luxletter installation!

einpraegsam commented 1 year ago

What if you open the TypoScript template module and check for luxletterPreviewNewsletter? What's the value for luxletterPreviewNewsletter.10.pluginName? Can you pls make a screenshot and post it here with all values?

alexingo commented 1 year ago

luxletterpreviewnewsletter

einpraegsam commented 1 year ago

That seems to be correct. So, the definition &tx_luxletter_preview[origin]=615 is a correct parameter for plugin Preview (called in FrontendController->previewAction). I would have to dig deeper.

Can you test LUXletter on a new TYPO3 system to ensure that now other extension or configuration has some side-effects?

alexingo commented 1 year ago

I will try to test, but it will take some time - Thanks so far!

alexingo commented 1 year ago

It works finally in a new installation, but unfortunenately I couldn't identify the cause of the error! Thanks for your fast replies and help!

einpraegsam commented 1 year ago

Strange, but thank you for your final feedback