search

in2code-de / luxletter

Newsletter system for TYPO3
https://www.in2code.de/agentur/typo3-extensions/luxletter/
24 stars 25 forks source link

Dashboard Filter Sites does not show any labels #224

Closed magicHatOfTYPO3 closed 3 months ago

magicHatOfTYPO3 commented 3 months ago

In the Luxletter (26.1.0) Dashboard the dropdown of the sites filter is populated with values (and it is functional), but the labels are missing.

luxletter-sites-filter

einpraegsam commented 3 months ago

Hi, I guess the value "websiteTitle" is emtpy or not set in your site configuration - right?

magicHatOfTYPO3 commented 3 months ago

confirm. If I set websiteTitle in config.yaml the label is shown.

Thanks for clarify this! :)

einpraegsam commented 3 months ago

Nevertheless, maybe it is a relevant case. Some installations keep websiteTitle empty because they don't want a title postfix "page | websiteTitle". Maybe we need a fallback for the label?

magicHatOfTYPO3 commented 3 months ago

The "identifier" might be a candidate for that, as it is set for any site configuration for sure.

einpraegsam commented 3 months ago

Thx, I will provide a fix within the next days

einpraegsam commented 3 months ago

I just release version 26.2.0 with a small fix. We are using now site.identifier instead of websiteTitle even if identifier could be meaningless in some smaller installations.