search

in2code-de / luxletter

Newsletter system for TYPO3
https://www.in2code.de/agentur/typo3-extensions/luxletter/
23 stars 25 forks source link

Hardcoded dependency to lux #93

Open georgringer opened 3 years ago

georgringer commented 3 years ago

The NewsletterController got a hardcoded dependency to lux with

$visitorRepository = ObjectUtility::getObjectManager()->get(VisitorRepository::class);
einpraegsam commented 3 years ago

Yes I know. Any problems with this? Or: How can I reproduce an error with this? Or is it just a code cleanup proposal?

georgringer commented 3 years ago

I don't know yet as I currently don't really need the backend modules but I will try to check

georgringer commented 3 years ago

I don't know when the ajax route for receiverDetailAjax is called but maybe only if lux is installed? however still a bad code small but fully understandable if you close the issue ;)