search

in2code-de / powermail

This is the official repository of the TYPO3 extension powermail! Powermail is a well-known, editor-friendly, powerful and easy mailform extension for TYPO3
https://in2code.de
88 stars 176 forks source link

Use constants instead of arbitrary ints in the code #1096

Open mgrundkoetter opened 2 months ago

mgrundkoetter commented 2 months ago

In the class In2code\Powermail\Domain\Validator\InputValidator in isValidFieldInStringValidation some "random" ints are used to identify the validator. This is bad style from a static analysis point of view and should be replaced by public constants in this class which can then also be used in derived classes.

mschwemer commented 2 months ago

Thanks. This is correct :-)

We plan to introduce static analysis in the next weeks for powermail and will consider it to improve the situation here.