search

in2code-de / powermail

This is the official repository of the TYPO3 extension powermail! Powermail is a well-known, editor-friendly, powerful and easy mailform extension for TYPO3
https://in2code.de
88 stars 174 forks source link

Update VariablesViewHelper.php #1151

Closed haraldwitt closed 1 month ago

haraldwitt commented 1 month ago

Patch for issues #1061 and #990

mschwemer commented 1 month ago

Hi Harald

Thanks for keeping track :-)

As I see your isolated patch, I remember, that there was already a PR, that I merged but lead to some other issues.

The original commit was f209418bb00262b8f4b04fd0ec549c71af8b2fe9; I reverted it in 4df7803c4b266b83568cb7f9b85f76b990e91d4d

The related issues were #974 and #976.

Can you elaborate, why the issues do not occur with your PR?

Thx Marcus

P.S.: I am quite "nervous" to accept a PR for the same line to achieve the same thing. I don't want to revert it in one of the next releases (again). Hope you understand.