[BUG] powermail pi1 thx form bodytext ignores configured rte preset

in2code-de / powermail

This is the official repository of the TYPO3 extension powermail! Powermail is a well-known, editor-friendly, powerful and easy mailform extension for TYPO3

https://in2code.de

86 stars 174 forks source link

[BUG] powermail pi1 thx form bodytext ignores configured rte preset #345

Closed Patta closed 5 years ago

Patta commented 5 years ago

For better UX it would be great if the powermail pi1 thx form bodytext could respect the configured rte preset (from a custom sitepackage or backend page tsconfig).

Behavior: This page TsConfig is ignored: RTE.default.preset = mycustompreset This page TsConfig is ignored: RTE.config.tx_powermail_domain_model_form.bodytext.preset = mycustompreset

Tested with: powermail 6.2.0 TYPO3 8.7.19 PHP 7.2

einpraegsam commented 5 years ago

Look at the FlexForm Definition - default was set correctly in my eyes: https://github.com/einpraegsam/powermail/blob/develop/Configuration/FlexForms/FlexformPi1.xml#L244

Patta commented 5 years ago

Shure. But custom presets are ignored.

Patta commented 5 years ago

Steps to reproduce this issue:

add own ckeditor configuration (e.g. like explained here)
add powermail pi1 plugin
open plugin option tab "Submit Page"
the own ckeditor configuration is ignored

Maybe there is a core / rte_ckeditor issue with ckeditor and flexform definitions.

Patta commented 5 years ago

I think this core / rte_ckeditor issue is related: ckeditor: custom config not loaded in flexform / problem determining pid

einpraegsam commented 5 years ago

Thx, so we have to wait until a fix in the core...

Patta commented 5 years ago

fixed in https://github.com/TYPO3/TYPO3.CMS/commit/8fc01bb9a19d0fa889720aa7baebd5b2bb90a4b4

einpraegsam commented 5 years ago

ok, let's wait until the upcoming bugfix release of TYPO3