in2code-de / powermail

This is the official repository of the TYPO3 extension powermail! Powermail is a well-known, editor-friendly, powerful and easy mailform extension for TYPO3
https://in2code.de
88 stars 174 forks source link

wrong client validation message when field is combined with required and regexp pattern #505

Closed gessulatgessulat closed 3 months ago

gessulatgessulat commented 4 years ago

Original error

Hello, I have a question about the javascript validators. it is a field of type input

TYPO3 8.7.30 powermail 7.0.0

After some investigations:

I think it has something to do with the underlying parsely library.

here the function _manageErrorsMessages is run through and it only checks if the current field has an error message "this.options.errorMessage" and prints it out.

Since the vh:Validation.ValidationDataAttribute sets viewhelper in HTML data-parsley-required-message and data-parsley-error-message. The data-parsley-error-message always wins here.

Although the parsely check fails on required, it displays the data parsley error message.

Can you reproduce this? I can make my ddiv available via ngrok to demonstrate.

i could reproduce this behavior also in following setups TYPO3 9.5.14 powermail 7.0.0 and powermail 7.4.0

wants to test it on TYPO3 10.2.2 but while issue https://github.com/einpraegsam/powermail/pull/504 exists. it not possible to work with.

Bildschirmfoto 2020-02-21 um 14 58 13

gessulatgessulat commented 4 years ago

i could also reproduce this behavior also in following setups

TYPO3 10.2.2 powermail 8.0.2

and TYPO3 10.3.0 powermail 8.0.2

mschwemer commented 3 months ago

We replaced parsely with a native js solution, so it does not apply to the current versions.

If you have still the same issue with current version, please open a new issue mentioning this one.