search

in2code-de / powermail

This is the official repository of the TYPO3 extension powermail! Powermail is a well-known, editor-friendly, powerful and easy mailform extension for TYPO3
https://in2code.de
88 stars 174 forks source link

[BUG] plugin.tx_powermail.settings.setup.receiver.overwrite.replyToEmail.value is ignored #557

Closed glucka closed 1 month ago

glucka commented 4 years ago

The settings 

plugin.tx_powermail.settings.setup.receiver.overwrite.replyToEmail.value 
plugin.tx_powermail.settings.setup.receiver.overwrite.replyToName.value

is ignored in v7 und v8 I make a PR now.

MrMooky commented 4 years ago

This is still the case in TYPO3 9.5.19 with Powermail 7.4.0. Basically, the constants are correctly set (as per TypoScript Object Browser), but these values are not forwarded when sending the email.

sendMail(array('template' => 'Mail/OptinMail', 'receiverEmail' => 'me@domain.de', 'receiverName' => 'Peter Griffin', 'senderEmail' => 'noreply@domain.de', 'senderName' => 'Test', 'replyToEmail' => '', 'replyToName' => '', 'subject' => 'Bitte bestätigen Sie Ihre Emailadresse', 'rteBody' => '', 'format' => 'both', 'variables' => array('hash ....

This bug is basically preventing us from using the Double OptIn feature.

MrMooky commented 4 years ago

The PR suggested by @glucka is working, but this should be made available in a TYPO3 9 compatible version. It appears the bug has been fixed in Powermail 8.0.0, which is only compatible with TYPO3 v10.

kurtkk commented 4 years ago

What shall we do now with powermail in TYPO3 V9!? Wait for a bugfix? Wait for a powermail-upgrade for TYPO3 V9?

MrMooky commented 4 years ago

Just implement the Commit mentioned above.

Teisi commented 4 years ago

@MrMooky can not confirm that this work for TYPO3 9....

glucka commented 4 years ago

@Teisi @MrMooky I use this in v9

MrMooky commented 4 years ago

@Teisi Worked as expected in our case with TYPO3 9.5.19 and Powermail 7.4.0

Teisi commented 4 years ago

@MrMooky what have you done exactly? I have copied and replaced the complete method "parseAndOverwriteVariables"...

MrMooky commented 4 years ago

@Teisi I only implemented the new lines mentioned here, nothing else.

Teisi commented 4 years ago

@MrMooky hmm, after the change, i'm not getting any e-mails at all... strange. I have to look closer... thank you.

kurtkk commented 4 years ago

The code of the commit above does not exist in Powermail V7.4.0 /powermail/Classes/Domain/Service/MailSendMailService.php !?

einpraegsam commented 3 years ago

I just tested powermail 7.4.0 (with latest TYPO3 9) and powermail 8.2.4 (with latest TYPO3 10) with this test settings:

plugin.tx_powermail.settings.setup.receiver.overwrite.replyToEmail = TEXT
plugin.tx_powermail.settings.setup.receiver.overwrite.replyToEmail.value = test@in2code.de
plugin.tx_powermail.settings.setup.receiver.overwrite.replyToName = TEXT
plugin.tx_powermail.settings.setup.receiver.overwrite.replyToName.value = test

The generated mail has this header:

Content-Type: multipart/alternative; boundary="_=_swift_v4_1607004812_5ae41346f23f0c89ad8d4cc07d18f88d_=_"
Date: Thu, 03 Dec 2020 15:13:32 +0100
From: defaultmailfromaddress <alexander.kellner@einpraegsam.net>
MIME-Version: 1.0
Message-ID: <626edb3fc09f52658672c4217fd71dde@powermail95.localhost.de>
Received: from powermail95.localhost.de by mailhog.example (MailHog)

          id TLwAk23GCK-kBa9qvoPZcebvrwvGdxc7B7GrKTkzUUY=@mailhog.example; Thu, 03 Dec 2020 15:13:32 +0100
Reply-To: test <test@in2code.de>
Return-Path: <alexander.kellner@einpraegsam.net>
Subject: [testparcours] New Email
To: Alex <alexander.kellner@in2code.de>
X-Mailer: TYPO3
X-Priority: 3 (Normal)

The question is: How can I reproduce the issue?

glucka commented 3 years ago

Maybe only if $GLOBALS['TYPO3_CONF_VARS']['MAIL']['defaultMailReplyToAddress'] is defined?

christophbee commented 2 years ago

After entering a mail address into $GLOBALS['TYPO3_CONF_VARS']['MAIL']['defaultMailReplyToAddress'] it works fine Thx @glucka

mschwemer commented 3 months ago

Needs further investigation together with the other email related stuff

mschwemer commented 1 month ago

Citing a comment It appears the bug has been fixed in Powermail 8.0.0, which is only compatible with TYPO3 v10.

So we are now on TYPO3 v12 and Powermail v12, I close this issue and the mentioned PR.

If you are still hit by this issue, please re-open it. Thx.