search

in2code-de / powermail_cond

Add conditions (via AJAX) to TYPO3 powermail forms for fields and pages
8 stars 23 forks source link

Display block is hardcoded. #92

Closed SicorDev closed 2 months ago

SicorDev commented 6 months ago

Hello,

our Design would require display:flex instead of display:block for showing hidden input fields. Maybe you can make that configurable? I'm sure other users would also require flex or grid eventually :-)

Greetings, Manuel

sbusemann commented 6 months ago

Can you please state where this should be?

I can only find display none

tantebootsy commented 2 months ago

I also need display:flex instead of display:block in some cases. E.g. if you use Bootstrap with "form-horizontal" the wrapper for the div holding the label and input-fields is set to flex. This is to set the input-field besides the label not beyond. display:block breaks the layout here, leading the input-field to move to a new line. Best thing would be to analyse the display-property of every single element before it gets hidden and then write back the individual property of every element, when it shall get shown again. I would like to have a look in the JS-code but it's obfuscated. Can you provide the source-files? Maybe I could then propose a patch.

Patta commented 2 months ago

@tantebootsy see https://github.com/in2code-de/powermail_cond/tree/develop/Resources/Private/Build/JavaScript

Patta commented 2 months ago

seems already fixed in v11 (for typo3 v12) https://github.com/in2code-de/powermail_cond/commit/a281ec790471233cb6b5d9a590bd60cce39f02ea

tantebootsy commented 2 months ago

ah, alright. of course that's a much simpler solution. :) thx for pointing me to this. i think this issue can be closed