in2code-de / powermailrecaptcha

Google recaptcha for powermail 3
10 stars 13 forks source link

Error when form is called after optinAction? #25

Open tastendruecker opened 1 year ago

tastendruecker commented 1 year ago

https://github.com/einpraegsam/powermailrecaptcha/blob/6220109c81bc5d113517ef9e15769364fe53fba2/Classes/Domain/Validator/SpamShield/RecaptchaMethod.php#L110

I think you should consider the case that a recaptcha validation is unnecessary or even worse may lead to errors when called from the optinAction. I would like to suggest to add that case to the condition like so:

return ($this->getActionName() === 'create' && $confirmationActive) || $this->getActionName() === 'optinConfirm';

sypets commented 7 months ago

Agree. Perhaps you can add a PR?

Also, "powermailcaptcha" is derived from this extension and has the same problem.

See

neufeind commented 1 month ago

Just stumbled across this issue as well. Not doing the spam-check for optin-confirm made it go away. Until fixed in the extension a workaround in typoscript is possible as well: https://github.com/in2code-de/powermail/issues/752#issuecomment-1324875732

siwa-pparzer commented 2 weeks ago

same for checkCreateAction if you have confirmation page active