Open tastendruecker opened 1 year ago
Agree. Perhaps you can add a PR?
Also, "powermailcaptcha" is derived from this extension and has the same problem.
See
Just stumbled across this issue as well. Not doing the spam-check for optin-confirm made it go away. Until fixed in the extension a workaround in typoscript is possible as well: https://github.com/in2code-de/powermail/issues/752#issuecomment-1324875732
same for checkCreateAction if you have confirmation page active
https://github.com/einpraegsam/powermailrecaptcha/blob/6220109c81bc5d113517ef9e15769364fe53fba2/Classes/Domain/Validator/SpamShield/RecaptchaMethod.php#L110
I think you should consider the case that a recaptcha validation is unnecessary or even worse may lead to errors when called from the optinAction. I would like to suggest to add that case to the condition like so:
return ($this->getActionName() === 'create' && $confirmationActive) || $this->getActionName() === 'optinConfirm';