search

in2code-de / publications

Follower of EXT:bib to show publications in TYPO3. Im- and export of bibtext and xml files.
https://www.in2code.de/agentur/typo3-extensions/publications/
11 stars 16 forks source link

Add pagination and optimize BibTeX import #21

Closed ipf closed 3 years ago

ipf commented 3 years ago

This PR adds a new pagination component, that is much more powerful and faster than the in-RAM-pagination currently offered. To achieve this, we added a standard pagination library (https://packagist.org/packages/pagerfanta/pagerfanta) as composer requirement. This currently only works in composer mode. For the non-composer-mode in a future PR the PHAR of the package needs to be provided (or any other clever solution). This also adds a lot of special chars to the BibTeX importer and adds the extensions key to composer.json, that is required (see https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ExtensionArchitecture/ComposerJson/Index.html#extra)

einpraegsam commented 3 years ago

Thx for the PR.

Here some general rules for PR that helps the author of an extension to keep the overview and to help that the PR is really merged: 1) Ask before a) If you would ask before making the PR, the change that the new (e.g.) feature gets merged will increase. Sometimes new features are not wanted or bugfixes are not really bugfixes if this could open a regression b) Some third party packages could generate unwanted dependencies.

2) Small changes a) If you would make small PRs (one per feature/bugfix), this would help to merge single ones (while others are maybe blocked) b) This also helps the author to easier understand relations between code and requirements

ipf commented 3 years ago

Hi, thanks for your remarks. I will split it up and create issues before to discuss the feature things