search

inCaller / prometheus_bot

Telegram bot for prometheus alerting
MIT License
395 stars 182 forks source link

Format output #8

Closed StereoRu closed 7 years ago

StereoRu commented 7 years ago

Hi I found interesting your project and use it. Thank you.

I made some changes that were necessary for me. If you find these changes helpful, can be used.

List of changes:

  1. Assembling the docker container via Makefile
  2. Change the location of the configuration file by default to config/config.yaml
  3. In the configuration file add parameters listen_addr and debug_bot
  4. Fixed crash the application when you send a message
  5. Added message formatting
hryamzik commented 7 years ago

Hi @StereoRu!

Looks like your PR conflicts with previous one (#7).

Change the location of the configuration file by default to config/config.yaml

Changing defaults is a bad practice I'd like to avoid here.

Added message formatting

Seem to be implemented in #7.

In the configuration file add parameters listen_addr and debug_bot

And removed command line option, that could break already running deployments. Please keep command line option in place with a higher priority to the one in configuration file. Both should be optional.

Fixed crash the application when you send a message

Can you provide some more details? What I can see in your code is that bot no longer reports chat ID to telegram, that's a good functionality that should be kept.

StereoRu commented 7 years ago

Sorry, this (#7) really more helpful.